Add delete to admin tab #2416
Add delete to admin tab #2416
Conversation
syed-ali-tw
force-pushed
the
admin-tab-delete-link
branch
16 times, most recently
from
2aee9b7 to
9a4acc4
Compare
| <%= render "govuk_publishing_components/components/button", { | ||
| text: "Skip fact check", | ||
| } %> | ||
| <div class="govuk-button-group"> |
There was a problem hiding this comment.
I don't think we should use the govuk-button-group class here and then over-ride it with a custom style. I think this class is designed to display multiple buttons and links horizontally so if that isn't what we want to do we should probably display those items as list items, the same as we do for the options sidebar on the edit page.
| def destroyable_edition? | ||
| return if @resource.can_destroy? | ||
|
|
||
| flash[:danger] = "Cannot delete a #{description(@resource).downcase} that has ever been published." |
There was a problem hiding this comment.
Is there any way that we can re-word this? Just worried that we could display something grammatically incorrect such as:
"Cannot delete a answer that has ever been published"
There was a problem hiding this comment.
This has been copied from existing error message and I think we have decided not to change error messages for now.
I have made the note of this to be added to the doc where we are maintaining list of all error messages to be reviewed.
syed-ali-tw
force-pushed
the
admin-tab-delete-link
branch
2 times, most recently
from
08e9e99 to
1ea08e7
Compare
| <% end %> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Looks like there's an extra closing </div> tag here.
There was a problem hiding this comment.
good spot, a carry over from confirm unpublish, have updated both files now
syed-ali-tw
force-pushed
the
admin-tab-delete-link
branch
from
1ea08e7 to
058a9f2
Compare
syed-ali-tw
force-pushed
the
admin-tab-delete-link
branch
from
058a9f2 to
eb7d05b
Compare
Trello
Add delete addition functionality to admin page.
Draft edition
fact check edition
confirm delete page
delete success message
Follow these steps if you are doing a Rails upgrade.