Design changes #2414
Merged
Design changes #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtrussler
force-pushed
the
407_Design-System_Edit-tab_design-updates
branch
from
c7f1425 to
20370cf
Compare
- Edit: - Increase depth of body field - Add rule above change note section - Metatags: - remove headings from label/legend
davidtrussler
force-pushed
the
407_Design-System_Edit-tab_design-updates
branch
from
20370cf to
2f67f6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
The changes in this PR make a couple of small changes on the Edit and Metadata tabs (screenshots below). The reason for the changes to the label/legend elements on the Metadata tag is to be consistent across Publisher and render these elements just as a
<label>or<legend>without wrapping them in a header tag which is better for accessibility.<h3>tags from the label and legend)