Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sub Navigation component to Edit page #2328

Merged

Conversation

syed-ali-tw
Copy link
Contributor

@syed-ali-tw syed-ali-tw commented Sep 16, 2024

Add sub nav items and default render show edit path for each of the sub nav items.

Note: Changes also include Gemfile.lock change although no gem file change, this is to update to latest publishing component gem.

sub nav items

@syed-ali-tw syed-ali-tw force-pushed the 448-implement-sub-navigation-publishing-component branch 12 times, most recently from a4ec41b to e1efb14 Compare September 19, 2024 10:56
@syed-ali-tw syed-ali-tw force-pushed the 448-implement-sub-navigation-publishing-component branch from e1efb14 to 8543562 Compare September 19, 2024 10:57
@syed-ali-tw syed-ali-tw marked this pull request as ready for review September 19, 2024 11:07
@davidtrussler davidtrussler changed the title Add reference to commit containing secondary navigation component cha… Add Sub Navigation component to Edit page Sep 19, 2024
Copy link
Contributor

@Tetrino Tetrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidtrussler davidtrussler merged commit 87c2595 into main Sep 20, 2024
13 checks passed
@davidtrussler davidtrussler deleted the 448-implement-sub-navigation-publishing-component branch September 20, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants