Migrate the Reports page to GOV.UK Design System #2026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
force-pushed
the
transition-reports-page-to-design-system
branch
from
b3ba7c0 to
a9b4f12
Compare
- Adds use of the [Page Title](https://components.publishing.service.gov.uk/component-guide/title) component to `app/views/layouts/design_system.html.erb` to ensure transitioned pages use consistent formatting for the page title. - Updates the reports index view to use the [Document List](https://components.publishing.service.gov.uk/component-guide/document_list) component. - Improves the test coverage around the reports controller. Since the transitioned design splits the generated message into two separate pieces of metadata (one for the time and one for the date), there will now be twice the calls to S3 to fetch that data. This could be optimised if it becomes a problem, but this page is not used much so that is left as a potential future optimisation.
patrickpatrickpatrick
force-pushed
the
transition-reports-page-to-design-system
branch
from
a9b4f12 to
4e3608e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app/views/layouts/design_system.html.erbto ensure transitioned pages use consistent formatting for the page title.Since the transitioned design splits the generated message into two
separate pieces of metadata (one for the time and one for the date),
there will now be twice the calls to S3 to fetch that data. This could
be optimised if it becomes a problem, but this page is not used much so
that is left as a potential future optimisation.
Follow these steps if you are doing a Rails upgrade.