Make the Change Note Modal wider #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
changed the title
patrickpatrickpatrick
force-pushed
the
make-modal-wider
branch
from
2843867 to
5f3a82a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add new modifier class that can be used to make the length of the modal wider on Desktop screen sizes. Add new class to the modal that is used for specifying the change note.
Why
It was requested that the change note modal be increased in width.
The modal will (likely) eventually be removed in the change to Design System, so this is a temporary measure until the move has been made.
Visual Differences
Before
After
Follow these steps if you are doing a Rails upgrade.