Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra rows to Edition notes textarea #2010

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

patrickpatrickpatrick
Copy link
Contributor

@patrickpatrickpatrick patrickpatrickpatrick commented Jan 16, 2024

What

Change the numbers of rows in the change note textarea modal.

Why

The edition note box is not big enough, meaning Content Designers cannot easily compose or work with the note in Publisher.

Visual Differences

Before

image

After

Screenshot 2024-01-16 at 16 03 29

Relevant Trello Card

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@patrickpatrickpatrick patrickpatrickpatrick changed the title Add extra rows to change note textarea Add extra rows to Edition notes textarea Jan 16, 2024
Copy link

@nnagewad nnagewad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good bud 👍🏽

@@ -18,7 +18,7 @@
<%= f.label :comment, "Edition note" %>
</span>
<span class="form-wrapper">
<%= f.text_area :comment, rows: 6, cols: 120, class: "form-control" %>
<%= f.text_area :comment, rows: 20, cols: 120, class: "form-control" %>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏽

Copy link
Contributor

@anatron anatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@patrickpatrickpatrick patrickpatrickpatrick merged commit 4f64c2c into main Jan 16, 2024
14 checks passed
@patrickpatrickpatrick patrickpatrickpatrick deleted the increase-row-change-note-modal branch January 16, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants