Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[186049138] Postgresql is used in acceptance tests #318

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

dark5un
Copy link
Contributor

@dark5un dark5un commented Nov 29, 2023

What

We are trying to eliminate any apt-get install remnants in our pipelines by loading requirements in the docker images.
This PR will include postgresql and postgresql-client needed in acceptance-tests.

How to review

Verify that the image contains postgresql and postgresql-client installed.

@dark5un dark5un force-pushed the 186049138-postgresql-in-cf-acceptance-tests branch 2 times, most recently from c794e22 to 074cc0f Compare November 30, 2023 09:28
@dark5un dark5un force-pushed the 186049138-postgresql-in-cf-acceptance-tests branch from 074cc0f to cae4481 Compare November 30, 2023 11:18
Copy link
Contributor

@corlettb corlettb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dark5un dark5un merged commit 9d7b912 into main Nov 30, 2023
34 checks passed
@dark5un dark5un deleted the 186049138-postgresql-in-cf-acceptance-tests branch November 30, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants