rescoped prometheus secrets and refactor manifest generation to use makefile #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackjoy-gds
force-pushed
the
185716198_rescope-prometheus-secrets-for-bosh
branch
2 times, most recently
from
5ac6880 to
e385d3b
Compare
jackjoy-gds
changed the title
jackjoy-gds
force-pushed
the
185716198_rescope-prometheus-secrets-for-bosh
branch
7 times, most recently
from
26da167 to
109a0e4
Compare
dark5un
approved these changes
Oct 17, 2023
jackjoy-gds
force-pushed
the
185716198_rescope-prometheus-secrets-for-bosh
branch
from
109a0e4 to
473625f
Compare
jackjoy-gds
deleted the
185716198_rescope-prometheus-secrets-for-bosh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
rescoped prometheus secrets to prep the use of the new makefile manifest generation
refactored pipeline manifest generation to use makefile
How to review
👀
run in a dev env
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨