Reduce memory usage of yace by splitting the staging process #3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corlettb
force-pushed
the
185715950-reduce-yace-memory
branch
4 times, most recently
from
cec8ffc to
9456b4e
Compare
risicle
reviewed
Sep 19, 2023
corlettb
force-pushed
the
185715950-reduce-yace-memory
branch
from
9456b4e to
5f5ede6
Compare
risicle
force-pushed
the
185715950-reduce-yace-memory
branch
from
5f5ede6 to
6205481
Compare
risicle
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reduce memory usage of yet-another-cloudwatch-exporter by splitting the staging process into two apps. The staging process will use 3GB and the running version will use 128MB.
Mask the AWS secret from the concourse logs.
Why
As part of the yet-another-cloudwatch-exporter upgrade we had to increase memory from 128M to 3GB. This was because the new aws client requires a lot of RAM to compile.
Sadly cloud foundry does not support different staging and running memory sizes. This process of downloading the droplet from one app and upload as another is a workaround to this issue.
How to review
Look at the changes.
Tested in dev05
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨