Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining missing headers to builder image. #57

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Oct 11, 2023

We're not using any of these yet, but it makes sense to ship headers in the builder image for all the libraries that we include in the base image. Should reduce the chance of being caught out next time some dependency starts requiring a native rubygem that depends on any of those libs.

We're not using any of these yet, but it makes sense to ship headers in
the builder image for all the libraries that we include in the base
image. Should reduce the chance of being caught out next time some
dependency starts requiring a native rubygem that depends on any of
those libs.
@sengi sengi requested a review from KludgeKML October 11, 2023 11:54
Copy link

@KludgeKML KludgeKML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sengi sengi merged commit 1b8d1ca into main Oct 11, 2023
2 checks passed
@sengi sengi deleted the sengi/headers branch October 11, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants