Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuke tests #2391

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ assignees: ''
<!-- What is happening vs what would you expect to happen instead? -->

## Environment (where applicable)
<!-- Details of your operating system, browser and the version of the GOV.UK Prototype Kit you’re using may help us to reproduce your issue. -->
<!-- Details of your operating system, browser and the version of the Now Prototype It Kit you’re using may help us to reproduce your issue. -->

- Operating system:
- Browser:
- Browser version:
- GOV.UK Prototype Kit version:
- Prototype Kit version:
9 changes: 2 additions & 7 deletions .github/workflows/test-acceptance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ jobs:
fail-fast: false # continue other tests if one test in matrix fails
matrix:
node-version: [20.x]
os: [macos-latest, windows-latest, ubuntu-latest]
type: [smoke, plugins, styles, dev, prod, errors]
os: [macos-latest, ubuntu-latest]
type: [plugins, dev]

name: Acceptance ${{ matrix.type }} test kit on Node v${{ matrix.node-version }} (${{ matrix.os }})
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -44,11 +44,6 @@ jobs:
- run: npm ci

- run: npm run test:acceptance:${{ matrix.type }}
env:
CYPRESS_REQUEST_TIMEOUT: 20000
CYPRESS_DEFAULT_COMMAND_TIMEOUT: 40000
CYPRESS_PAGE_LOAD_TIMEOUT: 120000
CYPRESS_RETRIES: 3

- if: ${{ failure() }}
uses: actions/upload-artifact@v3
Expand Down
32 changes: 0 additions & 32 deletions .github/workflows/test-heroku.yaml

This file was deleted.

4 changes: 3 additions & 1 deletion .github/workflows/validate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,6 @@ jobs:
steps:
- uses: actions/checkout@v3

- run: npx govuk-prototype-kit@snapshot validate-plugin
- run: npm ci

- run: ./bin/cli validate-plugin validate-plugin
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
lts/iron
v18.19.0
Loading
Loading