Merge pull request #2380 from alphagov/only-display-packages-with-a-p…

…lugin-config Only display packages that are plugins
alphagov · Nov 23, 2023 · 1afd0e4 · 1afd0e4
2 parents f7d87a9 + 205c49a
commit 1afd0e4
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Fixes
+
+- [#2380: Only display packages that are plugins](https://github.com/alphagov/govuk-prototype-kit/pull/2380)
+
 ## 13.15.2
 
 ### Fixes

diff --git a/lib/manage-prototype-handlers.js b/lib/manage-prototype-handlers.js
@@ -437,7 +437,8 @@ function buildPluginData (pluginData) {
 }
 
 async function prepareForPluginPage (isInstalledPage, search) {
-  const allPlugins = await getAllPackages()
+  const allPackages = await getAllPackages()
+  const allPlugins = allPackages.filter(({ pluginConfig }) => !!pluginConfig)
   const installedPlugins = await getInstalledPackages()
 
   const plugins = isInstalledPage

diff --git a/lib/manage-prototype-handlers.test.js b/lib/manage-prototype-handlers.test.js
@@ -91,7 +91,7 @@ jest.mock('./plugins/plugins', () => {
 })
 
 jest.mock('./plugins/packages', () => {
-  const availablePackage = {
+  const packageWithPluginConfig = {
     packageName: 'test-package',
     installed: false,
     available: true,
@@ -101,18 +101,31 @@ jest.mock('./plugins/packages', () => {
       '2.0.0',
       '1.0.0'
     ],
+    packageJson: {},
+    pluginConfig: {}
+  }
+  const packageWithoutPluginConfig = {
+    packageName: 'test-package-not-a-plugin',
+    installed: false,
+    available: true,
+    required: false,
+    latestVersion: '2.0.0',
+    versions: [
+      '2.0.0',
+      '1.0.0'
+    ],
     packageJson: {}
   }
   return {
     lookupPackageInfo: jest.fn().mockImplementation((packageName) => {
-      if (packageName === availablePackage.packageName) {
-        return availablePackage
+      if (packageName === packageWithPluginConfig.packageName) {
+        return packageWithPluginConfig
       } else {
         return undefined
       }
     }),
     getInstalledPackages: jest.fn().mockResolvedValue([]),
-    getAllPackages: jest.fn().mockResolvedValue([availablePackage]),
+    getAllPackages: jest.fn().mockResolvedValue([packageWithPluginConfig, packageWithoutPluginConfig]),
     getDependentPackages: jest.fn().mockResolvedValue([]),
     getDependencyPackages: jest.fn().mockResolvedValue([])
   }