Upgrade to node 20

alphagov · Oct 20, 2023 · 0384c9e · 0384c9e
1 parent 9c13ca5
commit 0384c9e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/test-acceptance.yaml b/.github/workflows/test-acceptance.yaml
@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false  # continue other tests if one test in matrix fails
       matrix:
-        node-version: [18.x]
+        node-version: [20.x]
         os: [macos-latest, windows-latest, ubuntu-latest]
         type: [smoke, plugins, styles, dev, prod, errors]
 

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false  # continue other tests if one test in matrix fails
       matrix:
-        node-version: [16.x, 18.x]
+        node-version: [18.x, 20.x]
         os: [macos-latest, windows-latest, ubuntu-latest]
 
     name: Test kit on Node v${{ matrix.node-version }} (${{ matrix.os }})

diff --git a/bin/cli b/bin/cli
@@ -2,10 +2,10 @@
 
 if (process.argv.indexOf('--suppress-node-version-warning') === -1 || (process.argv[2] === 'migrate' && process.argv[3] === '--')) {
   const majorNodeVersion = parseInt(process.version.split('.')[0].substring(1), 10)
-  const versionIsWithinRecommendation = majorNodeVersion === 18 || majorNodeVersion === 16
+  const versionIsWithinRecommendation = majorNodeVersion === 20 || majorNodeVersion === 18
   if (!versionIsWithinRecommendation) {
     const nodeVersionIsTooOldToUse = majorNodeVersion < 14
-    const updateOrDownload = majorNodeVersion < 18 ? 'update to' : 'download'
+    const updateOrDownload = majorNodeVersion < 20 ? 'update to' : 'download'
     const printLn = nodeVersionIsTooOldToUse ? console.error.bind(console) : console.warn.bind(console)
     const additionalText = nodeVersionIsTooOldToUse ? '' : ' Some features may not work with your version.'