Fix image build cronjobs. #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now the required permissions for the reusable build/push workflow.
samsimpson1
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update their permissions to work with the current version of the reusable build/push workflow.
Failures looked like:
Error calling workflow 'alphagov/govuk-infrastructure/.github/workflows/build-and-push-image.yml@main'. The nested job 'build-and-push-image' is requesting 'id-token: write', but is only allowed 'id-token: none'.While we're there, spread out the cronjob timings and use the same terminology in the workflow names as the reusable workflow.
Test runs: