Skip to content

Commit

Permalink
Remove clamv_db_efs
Browse files Browse the repository at this point in the history
Description:
- https://github.com/alphagov/govuk-infrastructure/pull/725/files introduced the EBS CSI Driver which created EFS for ClamAV
- Next https://github.com/alphagov/govuk-helm-charts/pull/508/files allowed ClamAV to talk to EFS over NFS exposing over clamav-db-govuk.integration.govuk-internal.digital
- However this didn’t work so ClamAV was switched to use the EFS CSI driver in https://github.com/alphagov/govuk-helm-charts/pull/514/files. But this removes the reference to clamav-db-govuk.integration.govuk-internal.digital
- #790 removes the EFS CSI driver
- Next https://github.com/alphagov/govuk-helm-charts/pull/572/files makes ClamAV share the EFS instance via the same NFS mount as asset manager.
- Now there is a dangling reference to ClamAV EFS instance which can be safely removed as nothing references it anymore.
- As part of alphagov/govuk-helm-charts#1883
  • Loading branch information
nimalank7 committed Dec 5, 2024
1 parent 7efa5fb commit 2aa3f81
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 39 deletions.
34 changes: 0 additions & 34 deletions terraform/deployments/cluster-infrastructure/clamav_db_efs.tf

This file was deleted.

4 changes: 0 additions & 4 deletions terraform/deployments/cluster-infrastructure/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,6 @@ output "monitoring_namespace" {
value = local.monitoring_namespace
}

output "clamav_db_efs_id" {
value = aws_efs_file_system.clamav-db.id
}

output "public_nat_gateway_ips" {
value = [for eip in aws_eip.eks_nat : eip.public_ip]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ resource "aws_efs_file_system" "assets_efs" {
creation_token = "blue-assets"
tags = {
"Name" = "asset-manager"
"Description" = "Asset Manager and Whitehall attachments are stored here temporarily for malware scanning before being transferred to S3."
"Description" = "ClamAV database configuration is stored here. Asset Manager and Whitehall attachments are stored here temporarily for malware scanning before being transferred to S3."
}
}

Expand Down

0 comments on commit 2aa3f81

Please sign in to comment.