Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NewBrowse A/B test #81

Merged
merged 1 commit into from
May 28, 2024
Merged

Remove NewBrowse A/B test #81

merged 1 commit into from
May 28, 2024

Conversation

unoduetre
Copy link
Contributor

@unoduetre unoduetre commented May 24, 2024 •
edited
Loading

Do not action until 28/05 (Tuesday)

What

Remove NewBrowse A/B test so we have full 7 days at 50%. This is related to the following PR.

Why

So that we can analyse the results and do the work properly if we were to move to lists

Trello card

Testing

I've confirmed in the Terraform diff that the changes introduced are as expected. The hash changes are discussed in this thread and they are confirmed to be harmless: https://gds.slack.com/archives/C013F737737/p1716550143651819?thread_ts=1716541278.025089&cid=C013F737737

@unoduetre unoduetre added the DO NOT MERGE USE DRAFTS INSTEAD I'm a sign not a cop label May 24, 2024
@unoduetre unoduetre requested a review from hannako May 24, 2024 11:25
@unoduetre
Remove NewBrowse A/B test
e82f118 
This reverts commits:
43fb595.
f1ebedd.
4ae312f.
and does some tiny code cleanup.
@unoduetre unoduetre force-pushed the 2615-remove-a-b-test-and-revert-list-pr-s-m branch from 8635070 to e82f118 Compare May 24, 2024 12:18
hannako
hannako approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unoduetre unoduetre marked this pull request as ready for review May 28, 2024 08:03
@unoduetre unoduetre closed this May 28, 2024
@unoduetre unoduetre reopened this May 28, 2024
@unoduetre unoduetre removed the DO NOT MERGE USE DRAFTS INSTEAD I'm a sign not a cop label May 28, 2024
@unoduetre unoduetre merged commit 872a997 into main May 28, 2024
4 checks passed
@unoduetre unoduetre deleted the 2615-remove-a-b-test-and-revert-list-pr-s-m branch May 28, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannako hannako hannako approved these changes

@richardTowers richardTowers richardTowers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unoduetre @richardTowers @hannako