Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tldredirect #69

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Migrate tldredirect #69

merged 6 commits into from
Apr 4, 2024

Conversation

MahmudH
Copy link
Contributor

@MahmudH MahmudH commented Mar 28, 2024

The VCL for this service was not migrated over to govuk-fastly. This PR creates the TLD Redirect Service in Infrastructure as Code.

Trello: https://trello.com/c/LqpDh7OR/3442-3-import-fastly-govuk-tld-redirect-service-into-terraform

@MahmudH MahmudH force-pushed the migrate-tldredirect branch from b17d89a to 31a71fb Compare April 3, 2024 13:19
AgaDufrat
AgaDufrat approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@AgaDufrat AgaDufrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Checked the diff while the TF state included the module.
We will need to re-import the module (apply will error if we don't).

@MahmudH MahmudH merged commit 9039f36 into main Apr 4, 2024
4 checks passed
@MahmudH MahmudH deleted the migrate-tldredirect branch April 4, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgaDufrat AgaDufrat AgaDufrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MahmudH @AgaDufrat