Add HTTP Strict-Transport-Security header to unknown URLs #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sengi
previously approved these changes
Feb 5, 2024
There was a problem hiding this comment.
The idea SGTM, but I have a couple of practical concerns about merging this as-is:
- do we plan to remove the HSTS stuff from apps? (I think we'll need to, otherwise we're duplicating the config for this important header, which just seems unnecessarily risky.)
- why the super short max-age?
modules/www/www.vcl.tftpl
Outdated
| @@ -452,6 +452,11 @@ sub vcl_miss { | |||
| } | |||
|
|
|||
| sub vcl_deliver { | |||
| # Add the HSTS header with a max-age of 5 mins to URLs that don't exist | |||
| if (!(resp.http.Strict-Transport-Security)) { | |||
| set resp.http.Strict-Transport-Security = "max-age=300"; includeSubDomains; preload | |||
There was a problem hiding this comment.
HSTS with max-age=300 doesn't seem useful to me — what's the rationale here?
There was a problem hiding this comment.
I see from the notes on the internal-only Trello card that you plan to set this to 300 and then increase it later, but that doesn't make any sense to me given that we're already serving HSTS headers with an appropriately-long max-age (strict-transport-security: max-age=31536000; preload).
sengi
dismissed
their stale review
didn't mean to approve there, sorry — comments kinda need addressing before merge
MahmudH
force-pushed
the
add-hsts-to-unknown-url
branch
from
0584a72 to
8f2acaf
Compare
|
tl;dr:
|
MahmudH
force-pushed
the
add-hsts-to-unknown-url
branch
from
8f2acaf to
f530131
Compare
sengi
reviewed
Feb 21, 2024
- This sets the HSTS header to the domain within VCL - Enables consistency throughout the CDN.
MahmudH
force-pushed
the
add-hsts-to-unknown-url
branch
from
f530131 to
d843f88
Compare
sengi
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/0TgCOgbX/3397-3-configure-fastly-to-always-append-an-hsts-header