Update data.gov.uk #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinjam
approved these changes
Jan 24, 2024
DGU has two domains www.data.gov.uk and data.gov.uk I’m not using `toset` as according to the docs explicit type conversions are rarely necessary in Terraform because it will convert types automatically where required. I’m using value because according to the dynamic block documentation: - key is the map key or list element index for the current element. If the `for_each` expression produces a set value then key is identical to value and should not be used - value is the value of the current element https://developer.hashicorp.com/terraform/language/expressions/dynamic-blocks
Since we only have one back end (no mirrors) for DGU those conditions are obsolete. `beresp.saintmode` marks the backend that was used for this request as unhealthy for the period of time specified.
Since we are using the default there's no need to declare it explicitly. This subroutine is executed when Fastly needs to calculate the address of an object in the cache.
AgaDufrat
force-pushed
the
update-dgu
branch
2 times, most recently
from
66aa4cf to
0df8f5b
Compare
to be able to import the terraform state. `terraform import module.datagovuk-integration.fastly_service_vcl.service $FASTLY_SERVICE_ID` was failing with "Value for undeclared variable" errors.
Generated with: `terraform import module.datagovuk-integration.fastly_service_vcl.service $FASTLY_SERVICE_ID`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed discrepancies in the plan diff.
Depends on