-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fastly config for mobile backend #104
Conversation
3e37110
to
bec4257
Compare
mobile-backend.tf
Outdated
source = "./modules/mobile-backend" | ||
|
||
environment = "integration" | ||
hostname = "app.integration.publishing.service.gov.uk" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI using a *.gov.uk
domain will cause the service creation to fail because Fastly requires manual approval to use gov.uk domains. You'll have to create a support ticket with them to get them to add the domains you want to the whitelist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if we have to create a service (i.e. with placeholder hostname) before contacting them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep turns out this ☝🏼 is correct - have updated the PR to include placeholder hostnames (on top of *.govuk.digital) so we can provide the service IDs to Fastly support
21ebae9
to
f7b2c00
Compare
f7b2c00
to
bf699e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some changes to the structure of the TF files in this PR since I made some structural changes to this repo yesterday.
This looks good to me, I've also created a PR in govuk-fastly-secrets which will be required to create the TFC workspace for the new service.
When you're ready, merge this PR in first then the govuk-fastly-secrets one.
Have tried to keep the config simple as it's a very straightforward use case. Rather than putting values in
govuk-fastly-secrets
(as I don't think we have any secret values currently) I've just set config vars in Terraform directly. But if we're not happy with this approach I can change it.I've also opted not to use a custom VCL as I think we can achieve everything we need to just by declaring it in TF. But I am pretty new at Fastly so again definitely will appreciate thoughts and views.
In order for this to work, assume we will also need to make some changes in
govuk-dns-tf
which I'll have a look at now.