Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the govuk_web_banners gem to render the currently live UR banner for the AI team #3474

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Use the govuk_web_banners gem to render the currently live UR banner for the AI team #3474

merged 3 commits into from
Dec 10, 2024

Conversation

hannako
Copy link
Contributor

@hannako hannako commented Dec 10, 2024 •
edited
Loading

Remove hardcoded banner configuration from this application

Update gemfile to pull in version 0.2.0 of the govuk-web-banners gem

No user facing changes, the banner will remain in place before and after this code change is deployed.

Trello

Review app links

Guides

base-path Review app Live site
/self-assessment-tax-returns Review app Live site
/self-employed-records Review app Live site
/expenses-if-youre-self-employed Review app Live site
/first-company-accounts-and-return Review app Live site
/capital-allowances Review app Live site
/simpler-income-tax-cash-basis Review app Live site
/capital-gains-tax Review app Live site
/directors-loans Review app Live site
/running-a-limited-company Review app Live site
/introduction-to-business-rates Review app Live site
/apply-for-business-rate-relief Review app Live site
/tax-codes Review app Live site

Answers

base-path Review app Live site
/working-for-yourself Review app Live site
/what-is-the-construction-industry-scheme Review app Live site
/expenses-and-benefits-a-to-z Review app Live site
/self-assessment-tax-return-forms Review app Live site
/calculate-tax-on-company-cars Review app Live site
/calculate-your-business-rates Review app Live site
/stop-being-self-employed Review app Live site

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3474 December 10, 2024 13:18 Inactive
@govuk-ci govuk-ci had a problem deploying to government-frontend-pr-3474 December 10, 2024 13:20 Failure
@hannako hannako mentioned this pull request Dec 10, 2024
Merged
hannako added a commit that referenced this pull request Dec 10, 2024
@hannako
Remove banner partial from application layout
d902088 
We will add this back in on #3474
@hannako hannako mentioned this pull request Dec 10, 2024
Merged
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3474 December 10, 2024 13:54 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3474 December 10, 2024 14:34 Inactive
@hannako
Use release 0.2.0 of the banner gem
3a3a58b 
This release will include the configuration removed in the previous commit.
alphagov/govuk_web_banners#28
@hannako
Add the banner partial to application layout
a2c8ef3 
This pulls in the user research banner partial defined in the govuk-web-banners gem.

This renders the banner in the same place on the page as was previously implemented.
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3474 December 10, 2024 14:38 Inactive
@hannako hannako marked this pull request as ready for review December 10, 2024 14:57
beccapearce
beccapearce approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@beccapearce beccapearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💪🏻

@hannako hannako merged commit 139c4a2 into main Dec 10, 2024
11 checks passed
@hannako hannako deleted the convert_banner branch December 10, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beccapearce beccapearce beccapearce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannako @beccapearce @govuk-ci