Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate correctly Welsh published date #3444

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

catalinailie
Copy link
Contributor

@catalinailie catalinailie commented Nov 27, 2024

All months in the published date component need to be translated.

Screenshot 2024-11-27 at 11 48 39

Trello card: https://trello.com/c/12ai7KMg/3072-allow-months-to-be-translated-in-the-published-dates-field-in-government-frontend-s

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3444 November 27, 2024 11:41 Inactive
Remove the hardcoded locale from `display_date` method
@catalinailie catalinailie force-pushed the translate-correctly-welsh-published-date branch from 82cadfe to 74979b8 Compare November 27, 2024 11:45
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3444 November 27, 2024 11:45 Inactive
Copy link
Contributor

@unoduetre unoduetre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@catalinailie catalinailie merged commit d7eeea1 into main Dec 2, 2024
11 checks passed
@catalinailie catalinailie deleted the translate-correctly-welsh-published-date branch December 2, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants