Remove GA4 tracking on 'print this page' buttons #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
changed the title
andysellick
approved these changes
Dec 11, 2023
| }, | ||
| }, | ||
| } %> | ||
| <%= render 'govuk_publishing_components/components/print_link', {} %> |
There was a problem hiding this comment.
This doesn't need the curly braces, it can just be:
<%= render 'govuk_publishing_components/components/print_link' %>
(also in a few other places)
There was a problem hiding this comment.
Thanks @andysellick - good spot, will fix this then merge 👍
We now have a tracker that tracks the browser print dialog, so we remove this tracking to prevent duplicate print events.
AshGDS
force-pushed
the
ga4-remove-print-page
branch
from
6cb470a to
8b9682e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes GA4 tracking on 'print page' buttons
Why
Pages affected
(Taken from #2513 )