Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Welsh translation for "We are analysing your feedback" #3003

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

deborahchua
Copy link
Contributor

Zendesk ticket - https://govuk.zendesk.com/agent/tickets/5571052

Trello card : https://trello.com/c/vHRwc0rr/2216-add-welsh-translations-for-we-are-analysing-your-feedback

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3003 December 6, 2023 13:05 Inactive
@deborahchua deborahchua marked this pull request as ready for review December 6, 2023 13:12
Copy link
Contributor

@JamesCGDS JamesCGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, thanks for taking a look @deborahchua! Would it be possible to also do a rebase to include the changes in this branch (this branch contains the translation for Summary)?

@deborahchua deborahchua force-pushed the add-welsh-translation-analysing-feedback branch from 9eb031b to 69a4a2b Compare December 6, 2023 15:35
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3003 December 6, 2023 15:35 Inactive
Tests were failing as 'Summary' wasn't included in the locale yml files
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3003 December 6, 2023 16:43 Inactive
Copy link
Contributor

@JamesCGDS JamesCGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KludgeKML KludgeKML merged commit c35133a into main Dec 7, 2023
11 checks passed
@KludgeKML KludgeKML deleted the add-welsh-translation-analysing-feedback branch December 7, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants