Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old GA4 code #2993

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Remove old GA4 code #2993

merged 1 commit into from
Nov 20, 2023

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Nov 17, 2023

This is no longer needed, as the GA4 data attributes are handled within the component (and data-ga4 was the old name for the attribute)

Example page: https://www.gov.uk/service-manual/helping-people-to-use-your-service

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@AshGDS AshGDS requested a review from andysellick November 17, 2023 14:50
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2993 November 17, 2023 14:50 Inactive
This is no longer needed, the GA4 data attributes are handled within the component
@AshGDS AshGDS force-pushed the remove-old-ga4-code branch from 2125111 to c75d1c6 Compare November 17, 2023 14:52
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2993 November 17, 2023 14:53 Inactive
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spotted 👍

@AshGDS AshGDS merged commit 4cad974 into main Nov 20, 2023
6 checks passed
@AshGDS AshGDS deleted the remove-old-ga4-code branch November 20, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants