Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phase banner left/right spacing on some pages #2988

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

andysellick
Copy link
Contributor

@andysellick andysellick commented Nov 14, 2023

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Fixes a problem with unneeded left/right padding around the phase banner.

  • below the tablet breakpoint (around 1020px) the phase banner at the top of some pages was being padded left and right, which indented it from the rest of the page
  • caused by the govuk-frontend grid wrapping classes, which were unnecessary
  • some wrapping divs moved instead to support the phase label, which is similar but does require additional wrapping elements
  • also remove some unnecessary logic

Example pages:

Why

Visual changes

Desktop - no change.

Tablet - change:

Before After
Screenshot 2023-11-14 at 13 30 12 Screenshot 2023-11-14 at 13 30 23

Mobile - change:

Before After
Screenshot 2023-11-14 at 13 31 54 Screenshot 2023-11-14 at 13 32 05

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2988 November 14, 2023 13:35 Inactive
@andysellick andysellick force-pushed the fix-phase-banner-layout branch from 43abe8f to b4c7e93 Compare November 14, 2023 13:36
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2988 November 14, 2023 13:37 Inactive
@andysellick andysellick marked this pull request as ready for review November 14, 2023 13:51
- below the tablet breakpoint (around 1020px) the phase banner at the top of some pages was being padded left and right, which indented it from the rest of the page
- caused by the govuk-frontend grid wrapping classes, which were unnecessary
- some wrapping divs moved instead to support the phase label, which is similar but does require additional wrapping elements
@andysellick andysellick force-pushed the fix-phase-banner-layout branch from b4c7e93 to bcbc033 Compare November 22, 2023 14:52
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2988 November 22, 2023 14:53 Inactive
@andysellick andysellick merged commit 7cc786c into main Nov 22, 2023
6 checks passed
@andysellick andysellick deleted the fix-phase-banner-layout branch November 22, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants