Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten GA4 attributes #2977

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Flatten GA4 attributes #2977

merged 1 commit into from
Nov 6, 2023

Conversation

andysellick
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What / why

  • we no longer need to nest GA4 attributes attached to elements, notably the index attributes
  • these attributes when collected by trackers are automatically nested based on the structure of the GA4 schema, held in the gem
  • flattening them here saves code and complexity

Visual changes

None.

Trello card: https://trello.com/c/IseA05Fd/644-remove-nesting-of-ga4-attributes

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2977 October 30, 2023 15:41 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2977 October 30, 2023 15:45 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2977 October 30, 2023 15:48 Inactive
@andysellick andysellick merged commit 376ca75 into main Nov 6, 2023
6 checks passed
@andysellick andysellick deleted the flatten-ga4 branch November 6, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshGDS AshGDS AshGDS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andysellick @AshGDS @govuk-ci