Remove legacy implementation of UR banner

alphagov · Dec 10, 2024 · 76181ce · 76181ce
1 parent aa2639f
commit 76181ce
Show file tree

Hide file tree

Showing 8 changed files with 5 additions and 122 deletions.
diff --git a/app/helpers/recruitment_banner_helper.rb b/app/helpers/recruitment_banner_helper.rb
diff --git a/app/views/content_items/answer.html.erb b/app/views/content_items/answer.html.erb
@@ -5,5 +5,4 @@
 
   <%= @requested_variant.analytics_meta_tag.html_safe if @requested_variant.present? %>
 <% end %>
-<%= render 'shared/intervention_banner' %>
 <%= render 'content_items/body_with_related_links' %>
diff --git a/app/views/content_items/detailed_guide.html.erb b/app/views/content_items/detailed_guide.html.erb
@@ -3,7 +3,6 @@
     schema: :faq
   ) %>
 <% end %>
-<%= render 'shared/intervention_banner' %>
 
 <%= render 'shared/email_subscribe_unsubscribe_flash', { title: @content_item.title_and_context[:title] } %>
 

diff --git a/app/views/content_items/document_collection.html.erb b/app/views/content_items/document_collection.html.erb
@@ -6,7 +6,6 @@
 
 <%= render 'shared/email_subscribe_unsubscribe_flash', { title: @content_item.title_and_context[:title] } %>
 
-<%= render 'shared/intervention_banner' %>
 <div class="govuk-grid-row">
   <div class="govuk-grid-column-two-thirds">
     <%= render 'govuk_publishing_components/components/title',
@@ -32,7 +31,7 @@
     <% if @content_item.important_metadata.any? %>
       <%= content_tag :div, class: "important-metadata inverse-background responsive-bottom-margin" do %>
         <%= render "govuk_publishing_components/components/metadata", {
-          inverse: true, 
+          inverse: true,
           other: @content_item.important_metadata,
           margin_bottom: 0,
         } %>

diff --git a/app/views/content_items/guide.html.erb b/app/views/content_items/guide.html.erb
@@ -18,7 +18,6 @@
 <% content_for :simple_header, true %>
 
 <div class="govuk-grid-row gem-print-columns-none">
-  <%= render 'shared/intervention_banner' %>
   <div class="govuk-grid-column-two-thirds">
     <%= render 'govuk_publishing_components/components/title', { title: @content_item.content_title } %>
     <% if @content_item.show_guide_navigation? %>

diff --git a/lib/data/recruitment_banners.yml b/lib/data/recruitment_banners.yml
diff --git a/test/integration/recruitment_banner_test.rb b/test/integration/recruitment_banner_test.rb
@@ -24,8 +24,8 @@ class RecruitmentBannerTest < ActionDispatch::IntegrationTest
       stub_content_store_has_item(content_item["base_path"], content_item.to_json)
       visit content_item["base_path"]
 
-      assert page.has_css?(".gem-c-intervention")
-      assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: "https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_2bggmg6xlelrO0S")
+      assert_not page.has_css?(".gem-c-intervention")
+      assert_not page.has_link?("Sign up to take part in user research (opens in a new tab)", href: "https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_2bggmg6xlelrO0S")
     end
   end
 
@@ -47,8 +47,8 @@ class RecruitmentBannerTest < ActionDispatch::IntegrationTest
       stub_content_store_has_item(content_item["base_path"], content_item.to_json)
       visit content_item["base_path"]
 
-      assert page.has_css?(".gem-c-intervention")
-      assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: "https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_2bggmg6xlelrO0S")
+      assert_not page.has_css?(".gem-c-intervention")
+      assert_not page.has_link?("Sign up to take part in user research (opens in a new tab)", href: "https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_2bggmg6xlelrO0S")
     end
   end
 

diff --git a/test/unit/helpers/recruitment_banner_helper_test.rb b/test/unit/helpers/recruitment_banner_helper_test.rb