Update ADR019-use-amazon-ses.md #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've just updated to reflect the fact that we do now use Notify to send emails to members of the public.
lfdebrux
approved these changes
Mar 25, 2024
|
It may be more appropriate to create an additional ADR specifically for sending confirmation emails. Let's discuss before we merge this. |
chao-xian
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Thanks @HollyCatling! Sorry this means I dropped the ball with an ADR missing about this bit specifically. I'll raise a new ADR to cover it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just updated to reflect the fact that we do now use Notify to send emails to members of the public.
PR Checklist
- (ADR, decision-record, engagement, research)
What
I've updated the ADR to reflect the fact that we now use Notify to send emails to memebers of the public.
How to review
Describe the steps required to test the changes.
For example:
Who can review
Describe who can review the changes. Or more importantly, list the people
that can't review, because they worked on it.