Update ruby to version 3.3.6 #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndajas
approved these changes
Nov 21, 2024
brucebolt
force-pushed
the
bump-ruby-3.3.6
branch
2 times, most recently
from
a845672 to
5b5c49e
Compare
`Rack::File` was deprecated in version 3 of Rack. It was then removed in version 3.1. We never used Rack 3.0 in this app, so missed the deprecation warning. It was only ever aliasing `Rack::Files` [1], so swapping one for the other. 1: https://github.com/rack/rack/blob/b11d4f57ca6cfbd93c0de7b2e08d08514d2f405c/lib/rack/file.rb
brucebolt
force-pushed
the
bump-ruby-3.3.6
branch
from
5b5c49e to
4bd3b72
Compare
JonathanHallam
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ruby to version 3.3.6.
Trello card