chore: flatten eip-7685 requests into a single opaque list #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
force-pushed
the
onbjerg/engine-api-flatten-requests
branch
from
882bb2f
to
60acd18
Compare
|
After some thinking we likely do not gain much by retaining the type here instead of using blobs, since validation is mostly a CL responsibility now, and system contracts adhering to EIP-7685 return the requests pre-serialized. For user-facing RPC it will matter more, but at that point in time it's ok to pay for the ser/de cost, while we'd likely want to avoid it during execution. Restructuring the PR. |
onbjerg
force-pushed
the
onbjerg/engine-api-flatten-requests
branch
3 times, most recently
from
e877abf
to
c9fcae4
Compare
onbjerg
force-pushed
the
onbjerg/engine-api-flatten-requests
branch
4 times, most recently
from
c5911ff
to
fd12107
Compare
onbjerg
requested review from
DaniPopes,
gakonst,
mattsse,
prestwich and
emhane
as code owners
onbjerg
force-pushed
the
onbjerg/engine-api-flatten-requests
branch
2 times, most recently
from
c093f3a
to
e2e6581
Compare
onbjerg
changed the title
This was referenced Oct 18, 2024
|
Looks like I need to update |
onbjerg
force-pushed
the
onbjerg/engine-api-flatten-requests
branch
from
e2e6581
to
9e2510f
Compare
onbjerg
force-pushed
the
onbjerg/engine-api-flatten-requests
branch
from
9e2510f
to
16a7f33
Compare
why? |
DaniPopes
approved these changes
Oct 18, 2024
mattsse
approved these changes
Oct 18, 2024
github-merge-queue bot
pushed a commit
to alloy-rs/op-alloy
that referenced
this pull request
Oct 18, 2024
## Motivation There is no longer a V4 execution payload in Pectra, so it does not make sense that there would be one for Optimism. The v4 payload envelope still exists, but it now wraps a v3 payload. See also alloy-rs/alloy#1383 Based on #175 ## Solution Remove the V4 payload. ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes --------- Co-authored-by: Yash Atreya <[email protected]>
refcell
pushed a commit
to alloy-rs/op-alloy
that referenced
this pull request
Oct 22, 2024
## Motivation There is no longer a V4 execution payload in Pectra, so it does not make sense that there would be one for Optimism. The v4 payload envelope still exists, but it now wraps a v3 payload. See also alloy-rs/alloy#1383 Based on #175 ## Solution Remove the V4 payload. ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes --------- Co-authored-by: Yash Atreya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The three different request fields have been replaced by a single field.
Requests over engine API will now be in an opaquely encoded format as defined by EIP-7685, and they will be in a single list.
See ethereum/execution-apis#591
Solution
Requests are now a list of opaque
Bytes. Additionally, the changes to the engine API also removes the need forExecutionPayloadV4, so I've removed that (and all variants of it).PR Checklist