Add service_id to filter metadata #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uladzislau-dziuba
force-pushed
the
add_service_id
branch
2 times, most recently
from
49dc752 to
491db00
Compare
uladzislau-dziuba
force-pushed
the
add_service_id
branch
from
491db00 to
486cdb6
Compare
uladzislau-dziuba
changed the title
uladzislau-dziuba
requested review from
Ferdudas97,
KSmigielski and
nastassia-dailidava
uladzislau-dziuba
changed the title
kozjan
approved these changes
Aug 12, 2024
kozjan
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
I'm approving but please also get @KSmigielski or @Ferdudas97 review
KSmigielski
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
service_idto filter metadata. https://github.com/allegro-internal/flex-roadmap/issues/644Testing process
service_idis present in node metadata it will be passed to the filters metadata.service_idvalue will be empty.