-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of Glob Patterns in extension of API related to URL paths #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
druminski
changed the title
Introduction of Glob Patterns in extension of API related to URL paths | WIP
Introduction of Glob Patterns in extension of API related to URL paths
Jul 19, 2024
KSmigielski
approved these changes
Aug 19, 2024
kozjan
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended API of envoy-control by adding the
paths
field inIncomingEndpoint
. The field can receive a set of values in the Glob Pattern format. The latest version of Envoy started to support Glob patterns by using the URI Template extension. In this PR we use the extension via thepaths
field.Warning
This PR supports also the
paths
field along with Glob Patterns in JWT Filter, but Envoy doesn't support the Glob Pattern in JWT Filter yet. It will do it soon thanks to this Pull Request. Until then, please don't use Glob Patterns with JWT Filter.