#624 Set flat priority only for services with traffic splitting #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastassia-dailidava
force-pushed
the
ts-priority-fix
branch
from
7df2532 to
51d3df9
Compare
KSmigielski
reviewed
Apr 24, 2024
| clusterLoadAssignment: ClusterLoadAssignment?, | ||
| trafficSplitting: TrafficSplittingProperties | ||
| ) = clusterLoadAssignment?.endpointsList | ||
| ?.any { e -> trafficSplitting.zoneName == e.locality.zone && e.lbEndpointsCount > 0 } ?: false |
There was a problem hiding this comment.
Why we no longer check if there are any endpoints?
There was a problem hiding this comment.
yea I think I had some justification when I was deleting it, but now don't recall why, so returned it back
There was a problem hiding this comment.
as I understand you had it tested here and it worked without checking endpoint count?
kozjan
reviewed
Apr 24, 2024
...core/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/SnapshotProperties.kt
Show resolved
Hide resolved
kozjan
reviewed
Apr 24, 2024
.../pl/allegro/tech/servicemesh/envoycontrol/snapshot/resource/clusters/EnvoyClustersFactory.kt
Outdated
Show resolved
Hide resolved
kozjan
reviewed
Apr 24, 2024
.../pl/allegro/tech/servicemesh/envoycontrol/snapshot/resource/clusters/EnvoyClustersFactory.kt
Outdated
Show resolved
Hide resolved
kozjan
reviewed
Apr 24, 2024
Co-authored-by: kozjan <[email protected]>
KSmigielski
approved these changes
Apr 24, 2024
kozjan
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added setting: "zonesAllowingTrafficSplitting", so changes in a config would be made only for envoys in that zone
Fixed setting priority for traffic splitting endpoints, they will be duplicated with higher priorities
closes allegro-internal/flex-roadmap#624
tests