fix(init): initialShardSize ignored HardMaxCacheSize, and so the init…

…ial size can exceed the limit (#228)
allegro · Jun 17, 2020 · bbbffd3 · bbbffd3
1 parent bbb395e
commit bbbffd3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/config.go b/config.go
@@ -68,7 +68,7 @@ func DefaultConfig(eviction time.Duration) Config {
 
 // initialShardSize computes initial shard size
 func (c Config) initialShardSize() int {
-	return max(c.MaxEntriesInWindow/c.Shards, minimumEntriesInShard)
+	return max(min(c.MaxEntriesInWindow/c.Shards, c.maximumShardSize()), minimumEntriesInShard)
 }
 
 // maximumShardSize computes maximum shard size

diff --git a/utils.go b/utils.go
@@ -7,6 +7,13 @@ func max(a, b int) int {
 	return b
 }
 
+func min(a, b int) int {
+	if a < b {
+		return a
+	}
+	return b
+}
+
 func convertMBToBytes(value int) int {
 	return value * 1024 * 1024
 }