Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Unity 5.3 methods #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch to Unity 5.3 methods #2

wants to merge 1 commit into from

Conversation

JohannesDeml
Copy link

Switch to SceneManager methods, because other methods are deprecated since unity 5.3, FIX some comment typos

I think this is the next step to keep this repository up to date.

…ecated since unity 5.3, FIX some comment typos
@aliessmael
Copy link
Owner

Hi. Johannes. Thanks for Commits
Will these changes support old unity users?

@JohannesDeml
Copy link
Author

Sadly they won't :(

@jamessa
Copy link
Contributor

jamessa commented Jan 23, 2016

In fact, I'd love to see theses changes in repository. Since 5.3 is currently the main stream version, you can expect more and more users bump into this problem. As a matter of fact, our next product will ship with 5.3.

I'd like to suggest that you can put a tag to current commit then state in readme for people want to use it in older version.

Thanks for making such a great tool.

@JohannesDeml
Copy link
Author

Thanks for encouraging to take my pull request. I think it still should not be included unless somebody integrates platform dependent compilation (http://docs.unity3d.com/Manual/PlatformDependentCompilation.html) to support older unity versions as well. The old methods are deprecated, but are still accessible.

I also think it would be an important step to move uGUI to have less performance issues and ultimately get a better UI.

@aliessmael
Copy link
Owner

In progress...

@aliessmael
Copy link
Owner

done. Thanks for useful commit.

@dongohu
Copy link

dongohu commented Apr 9, 2016

I would suggest to add :
#pragma warning disable 618
at the beginning and :
#pragma warning restore 618
at the end of Reporter.cs & TestReporter.cs

This will force Unity to not display any obsolete warning that might come around in the editor for those 2 scripts.

@aliessmael
Copy link
Owner

This will work if you are using latest unity version, but will not for old version

@jcrombez
Copy link

Any news about that PR ? It would be nice to remove all those notices :)

@GabLeRoux
Copy link

GabLeRoux commented Dec 10, 2018

This pull request is getting old. The fixes for the typos should be merged.
SceneManager.LoadScene replacement should be wrapped in Unity versions conditions to keep backward compatibility.
Branch has merge conflicts too.

Not sure if this project is still maintained, but this pull request should be updated or closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants