[bin] Import correct Graph objects for meshroom_batch
#2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
fix/importMeshroomBatch
branch
from
7faf662
to
2b590c3
Compare
Just-Kiel
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue introduced by 41e885d which, among other things, removed unused imports from files.
In the case of
multiview.py, graph objects were imported while never being used in the file itself. It was however imported inmeshroom_batchwhich then used these graph objects. With the imports being removed frommultiview.py,meshroom_batchcould not access them anymore.The import of
multiviewinmeshroom_batchis effectively removed and replaced with the direct imports from thegraphmodule.