Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Several Compatibility Nodes Operations #2506

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Just-Kiel
Copy link
Contributor

@Just-Kiel Just-Kiel commented Aug 20, 2024

Description

  • Recompute and Re-Submit not allowed for Compatibility Nodes because they are not computable nodes

@Just-Kiel Just-Kiel added this to the Meshroom 2024.1.0 milestone Aug 20, 2024
@Just-Kiel Just-Kiel self-assigned this Aug 20, 2024
@Just-Kiel Just-Kiel force-pushed the fix/compatibilityNodesOperations branch 3 times, most recently from a92d80d to 0a08336 Compare September 2, 2024 12:20
Renaming of canCompute to canComputeTopologically to understand the static aspect of the function
@fcastan fcastan force-pushed the fix/compatibilityNodesOperations branch 2 times, most recently from ab82d8b to b6df285 Compare September 13, 2024 16:51
@fabiencastan fabiencastan merged commit 58741a3 into develop Sep 13, 2024
3 of 4 checks passed
@fabiencastan fabiencastan deleted the fix/compatibilityNodesOperations branch September 13, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants