Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #329 : Add configurability to ImagePullPolicy to support offline environments by allowing IfNotPresent option. #330

Merged

Conversation

shangjin92
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2024

CLA assistant check
All committers have signed the CLA.

@shangjin92
Copy link
Contributor Author

@Lyt99 PTAL. By the way, is this project still being updated? It seems like a long time since the last release version was published.

@Lyt99
Copy link
Collaborator

Lyt99 commented Dec 12, 2024

@Lyt99 PTAL. By the way, is this project still being updated? It seems like a long time since the last release version was published.

Hi, thanks for your contribution!

This project is still being updated. We're reviewing the features and architecture for the project, so the progress has slowed down for a while. We almost finished the internal review, and it will be back to activate development soon.

pkg/skoop/collector/manager/manager.go Outdated Show resolved Hide resolved
@Lyt99
Copy link
Collaborator

Lyt99 commented Dec 12, 2024

@Lyt99

And also, please sign the CLA, thanks :)

@shangjin92
Copy link
Contributor Author

CLA signed, and code updated. This tool looks great! Hope to see it continue to grow and develop.

@shangjin92 shangjin92 force-pushed the feature/support-imagepullpolicy-setting branch from 49d0268 to 0e36b37 Compare December 12, 2024 10:05
@shangjin92 shangjin92 force-pushed the feature/support-imagepullpolicy-setting branch from 0e36b37 to 616d5d0 Compare December 12, 2024 10:13
@Lyt99 Lyt99 merged commit 05c2d69 into alibaba:main Dec 13, 2024
9 checks passed
@Lyt99
Copy link
Collaborator

Lyt99 commented Dec 13, 2024

The pr has been merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants