Fix/addnodes skip empty ip #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vvhuang-ll
force-pushed
the
fix/addnodes-skip-empty-ip
branch
from
fd160ef to
6e7a5d3
Compare
…ing added to the graph, causing downstream errors or unnecessary node creation.
vvhuang-ll
force-pushed
the
fix/addnodes-skip-empty-ip
branch
from
6e7a5d3 to
a0ab5b8
Compare
|
LGTM, thanks for your contribution! |
Lyt99
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
srcordstIP fields are non-empty before creating and adding nodes to the graph.Related Issue:
Fixes invalid node addition when IPs are empty in the
FlowGraphimplementation.#327
Test plan:
srcanddstIPs to ensure nodes are created as expected.srcordstIPs.srcordstis empty, ensuring only valid nodes are added."