fix(core): array field insert method crash in sparse array #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dan0314
changed the title
dan0314
changed the title
dan0314
force-pushed
the
fix/core-patch-field-states-in-lazy-array
branch
from
f8f3527
to
c68d550
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## formily_next #3987 +/- ##
=============================================
Coverage 99.55% 99.55%
=============================================
Files 152 152
Lines 6709 6716 +7
Branches 1876 1819 -57
=============================================
+ Hits 6679 6686 +7
- Misses 29 30 +1
+ Partials 1 0 -1
☔ View full report in Codecov by Sentry. |
janryWang
reviewed
Oct 12, 2023
| @@ -167,6 +167,11 @@ export const patchFieldStates = ( | |||
| } | |||
| } | |||
| }) | |||
| Object.keys(target).forEach((id)=> { | |||
| if(target[id] === undefined){ | |||
| delete target[id] | |||
There was a problem hiding this comment.
那加个问号是不是就行了？这个 PR 的改动逻辑时间复杂度有点高
dan0314
force-pushed
the
fix/core-patch-field-states-in-lazy-array
branch
from
c68d550
to
3915838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
masterorformily_next.npm test).npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.Please do not delete the above content
What have you changed?
#3932