fix(interactive): Implement HttpIrMetaReader to Get Meta Data From Remote Http Service
#3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siyuan0322
previously approved these changes
Jun 11, 2024
longbinlai
reviewed
Jun 12, 2024
| @@ -1,45 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
The file should be completely removed?
longbinlai
reviewed
Jun 12, 2024
| @@ -23,6 +23,13 @@ compiler: | |||
| - FilterIntoJoinRule | |||
| - FilterMatchRule | |||
| - NotMatchToAntiJoinRule | |||
| meta: | |||
| reader: | |||
| mode: local | |||
There was a problem hiding this comment.
This still runs in local mode?
longbinlai
reviewed
Jun 12, 2024
| @@ -61,3 +61,15 @@ calcite.default.charset: UTF-8 | |||
|
|
|||
| # set the max capacity of the result streaming buffer for each query | |||
| # per.query.stream.buffer.max.capacity: 256 | |||
|
|
|||
| # set the mode to read ir meta, either from a 'local' file or via remote 'http'. | |||
| # ir.meta.reader.mode: local | |||
There was a problem hiding this comment.
The configuration of ir.meta.xx, should be uniformly defined with graph.schema and graph.statistics. In addition, we can really configure those service scheme, to automatically differentiate from local and http. For example,
graph.meta.statistics.uri: http://localhost:8080 -> this is a http file, or
graph.meta.statistics.uri: file:///path/to/local/file -> this is a local file
Also give a uri for schema
BingqingLyu
previously approved these changes
Jun 13, 2024
…istency results in query
siyuan0322
previously approved these changes
Jun 25, 2024
zhanglei1949
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
HttpIrMetaReaderto get meta data from remote http service.DynamicIrMetaFetcherto fetch schema or statistics periodically, the interval can be set by configurations.Related issue number
Fixes