fix(interactive): Support using interactive on macos #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglei1949
changed the title
Interactive errorsInteractive bugs
zhanglei1949
changed the title
Interactive bugsauthor xiaolei.zl <[email protected]> 1702281922 +0800 committer xiaolei.zl <[email protected]> 1703038800 +0800 stash script change decude warning update script fix bug in gs_interactive fix get_current_dir() update dockerfile and readme revert unnecessary changes make interactive-base:latest on remote add makefile fix fix dockerfile update dockerfile minor fix refine readme minor update readme update readme fix use v0.0.2.5
zhanglei1949
force-pushed
the
fix-interactive
branch
from
aa86dbe to
500c45e
Compare
siyuan0322
previously approved these changes
Dec 20, 2023
lidongze0629
previously approved these changes
Dec 20, 2023
zhanglei1949
dismissed stale reviews from lidongze0629 and siyuan0322
via
62b1838
zhanglei1949
changed the title
siyuan0322
approved these changes
Dec 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3416 +/- ##
=======================================
Coverage 40.90% 40.90%
=======================================
Files 109 109
Lines 11343 11343
=======================================
Hits 4640 4640
Misses 6703 6703 Continue to review full report in Codecov by Sentry.
|
lidongze0629
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3414
gs_interactive.interactive-runtime.Dockerfilefor supporting building image on and foraarch64machine.