Fix augmented assignment bug

[daniel-makerx]

Ensures expressions are not double evaluated when lowering AWST to IR

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
src/puya_lib
arc4.py	126	126	0%	1–332
bytes.py	9	9	0%	1–15
util.py	16	16	0%	1–33
src/puya
__main__.py	30	30	0%	1–42
arc32.py	71	2	97%	78, 104
arc56.py	76	2	97%	277, 283
artifact_sorter.py	53	1	98%	84
compile.py	160	8	95%	92–93, 135–138, 158–161, 317, 365
context.py	31	1	97%	35
errors.py	35	8	77%	40–42, 44–46, 50–51
log.py	199	40	80%	32–35, 69, 89, 123–124, 166–168, 171–173, 175, 188–197, 219, 288–289, 298, 326–328, 341–355
main.py	36	36	0%	1–49
parse.py	87	5	94%	31, 40, 50, 56, 87
utils.py	201	18	91%	50, 67–68, 77–78, 86–87, 177, 195–197, 204, 212, 226, 249, 251, 274, 309
src/puya/awst
function_traverser.py	288	3	99%	76, 367, 373
nodes.py	989	40	96%	100, 104–107, 147, 151–154, 355, 552, 568, 602, 643, 672–673, 723, 750–751, 900, 922, 954, 980, 985, 1140, 1225, 1241, 1290, 1367, 1448, 1502, 1506, 1629, 1774, 1779, 1784, 1792, 1797, 1802
serialize.py	68	11	84%	24, 84–89, 95–98
to_code_visitor.py	423	8	98%	131, 242, 279, 325, 581, 606, 634, 638
txn_fields.py	98	1	99%	48
wtypes.py	330	18	95%	174, 178–181, 195–196, 200, 230, 243, 254, 259–260, 294, 332, 346, 396, 519
src/puya/awst/validation
arc4_copy.py	110	1	99%	38
base_invoker.py	47	4	91%	55, 62, 72–76
immutable.py	31	2	94%	26, 34
inner_transactions.py	187	1	99%	160
labels.py	30	8	73%	25–27, 32, 36–41
scratch_slots.py	38	4	89%	18, 32, 47, 49
src/puya/ir
arc4_router.py	283	19	93%	112, 175, 231, 309, 357, 429, 442, 500–501, 513, 518, 523, 528, 533, 538, 558–562, 695, 732
avm_ops.py	323	1	99%	46
avm_ops_models.py	50	3	94%	21, 30, 38
context.py	101	8	92%	68, 75, 78, 80, 118–119, 129, 135
main.py	392	14	96%	77–83, 93–99, 125, 138, 166, 544, 779–783
models.py	530	22	96%	74, 182, 189, 338, 408–409, 414, 420–424, 437, 481, 510, 566, 612, 692, 708, 749, 752, 759, 762, 851–852
ssa.py	130	3	98%	51–52, 150
to_text_visitor.py	152	7	95%	123, 212, 219–224
types_.py	101	10	90%	50, 57, 91–95, 116, 152, 157–159
visitor.py	129	17	87%	145, 193, 205, 220, 223, 236, 239, 245, 248, 259, 262, 265, 268, 271, 274, 277, 280
visitor_mutator.py	105	2	98%	174–175
vla.py	72	1	99%	87
src/puya/ir/builder
_utils.py	136	5	96%	229–231, 293–300
arc4.py	500	21	96%	173–178, 477, 480, 538–541, 813–814, 1060, 1084, 1165, 1172, 1208, 1256, 1266, 1321, 1366, 1385, 1405
assignment.py	94	7	93%	100, 115, 189, 208, 225–226, 271
blocks.py	140	7	95%	55, 92–96, 158, 166, 231
bytes.py	64	14	78%	13–45, 129
callsub.py	81	5	94%	33–34, 59, 109–110
flow_control.py	95	1	99%	56
iteration.py	198	5	97%	91–92, 107, 144, 206
itxn.py	323	37	89%	139–140, 142, 156, 164–169, 197, 204, 226–227, 560, 579–597, 666, 670, 684, 693–706
main.py	590	68	88%	127, 267, 271, 276–295, 300–319, 374, 398, 419, 437–438, 440, 448, 490, 679, 711, 724–725, 773, 798, 835–837, 848, 913, 991, 1004, 1036, 1101, 1104, 1112, 1115, 1123, 1154, 1180, 1189, 1313, 1330, 1373–1383
storage.py	83	2	98%	101, 154
src/puya/ir/destructure
coalesce_locals.py	101	19	81%	119, 128–129, 132–135, 138–147, 163–166
parcopy.py	84	2	98%	47, 83
src/puya/ir/optimize
collapse_blocks.py	92	5	95%	65–69
compiled_reference.py	79	5	94%	53, 87, 158–163
control_op_simplification.py	104	7	93%	47–48, 171, 245–252
inner_txn.py	36	1	97%	38
intrinsic_simplification.py	483	31	94%	76, 166–168, 173, 255, 267, 302, 313–314, 338–339, 363, 430, 617, 619, 634, 674, 697, 727, 733, 735, 737, 742, 744, 746, 748, 750, 802–803, 810
main.py	87	2	98%	118–119
src/puya/ir/validation
_base.py	30	1	97%	28
compile_reference_validator.py	20	2	90%	24, 30
min_avm_version_validator.py	15	4	73%	16–20
op_run_mode_validator.py	19	5	74%	19–29
src/puya/mir
aligned_writer.py	63	3	95%	21, 61, 80
builder.py	157	13	92%	71–73, 156, 268–269, 322, 325, 328, 331, 334, 337, 340
models.py	432	6	99%	97, 206, 250, 316, 333, 403
src/puya/mir/stack_allocation
f_stack.py	89	2	98%	23, 70
peephole.py	48	2	96%	47, 49
x_stack.py	205	3	99%	32, 336–340
src/puya/teal
models.py	364	2	99%	377, 438
src/puya/teal/optimize
constant_block.py	104	4	96%	63, 152, 189, 206
peephole.py	127	3	98%	162, 168, 251
repeated_rotations.py	51	1	98%	16
repeated_rotations_search.py	90	6	93%	35, 41–42, 58, 68–69
src/puya/ussemble
assemble.py	171	5	97%	134, 202, 219–220, 260
models.py	25	1	96%	16
op_spec_models.py	22	1	95%	20
src/puyapy
__main__.py	64	17	73%	178, 190–204, 208
client_gen.py	118	11	91%	65–66, 84–88, 92, 205, 212–213, 231
compile.py	150	22	85%	59–68, 82, 164–165, 176, 183–184, 201–211, 221–223, 228, 244
models.py	99	4	96%	65, 77–79
parse.py	180	13	93%	49–50, 86, 158–163, 167, 265, 269–270, 317, 329, 354
template.py	32	8	75%	10–11, 18–19, 27–28, 34, 37
utils.py	21	5	76%	16–17, 25–28
src/puyapy/awst_build
arc4_client.py	104	24	77%	46–50, 58, 70, 76, 80, 109, 115–116, 122, 125, 128, 134, 137, 145, 148, 151, 154, 157, 160, 163, 166, 169, 172
arc4_client_gen.py	127	8	94%	31, 89–90, 100, 102, 117–118, 185
arc4_utils.py	288	47	84%	42, 45–46, 48, 53–60, 78, 89–93, 109, 111, 114–115, 138, 181–183, 192, 197, 202–203, 229, 233, 245, 252, 254, 268–269, 272–276, 281–282, 288–291, 299, 307, 324, 336, 344, 446, 451, 470
base_mypy_visitor.py	127	39	69%	70–76, 94, 102–115, 129, 131, 133, 145, 150, 154, 157, 160, 166, 188, 191, 194, 201, 205, 208, 211, 215, 233, 237, 241, 245, 249, 253, 257, 261, 265, 269, 273, 277, 281
context.py	218	47	78%	55, 58, 68–69, 87–88, 128, 188, 193, 199–203, 207, 210, 219, 221, 224–226, 228, 235, 237, 248–249, 254–256, 259, 274, 286–287, 299, 313, 316–328
contract.py	319	33	90%	128, 179, 192–196, 236, 238, 242, 246, 254, 262, 264, 284, 339, 342, 354, 362, 365, 368, 371, 374, 377, 380, 383, 386, 389, 449–453, 502–506, 586–590, 661, 684
intrinsic_models.py	49	1	98%	55
main.py	36	1	97%	31
module.py	429	59	86%	118, 138, 144–148, 163–164, 171, 180–181, 189–193, 215, 244, 264–265, 276, 298–301, 311–313, 319, 336–339, 352, 386, 393, 415–416, 439–444, 498–499, 527, 538, 541, 547, 553, 563, 569, 572, 584, 587, 610, 630, 635, 639, 648–652, 744, 752, 754
pytypes.py	594	60	90%	87, 97–99, 104, 111, 116–118, 122–124, 151–152, 192, 208–214, 237, 257, 299, 337–339, 368, 434, 443, 462, 482, 504–505, 647–649, 663–664, 731–732, 836, 847–848, 897–898, 903, 956–957, 980–981, 1132–1133, 1157, 1185, 1219–1221, 1261, 1271–1272
subroutine.py	602	52	91%	135, 245, 251, 309–312, 318, 369, 374, 377–383, 474, 494, 649, 651–652, 670, 672, 682–683, 692–693, 697, 718, 784, 791, 811–812, 896, 922–923, 940, 956, 980, 988, 999, 1025–1028, 1134–1135, 1155, 1165, 1167, 1176, 1194, 1202, 1216, 1219, 1222, 1225, 1228
utils.py	161	24	85%	30, 47–51, 69, 104–105, 107, 151–152, 203, 211, 216, 229–233, 238–241, 250, 254, 262
src/puyapy/awst_build/eb
_base.py	128	18	86%	52, 57–59, 64, 71, 76, 81–83, 142, 153, 183, 188, 193, 198, 209, 223–225
_bytes_backed.py	48	2	96%	30–31
_expect.py	122	21	83%	26, 37, 87–90, 102–105, 108, 160–161, 219–222, 232–235
_literals.py	144	29	80%	44, 73, 92, 121, 138, 152, 156, 160–166, 176–190, 195
_type_registry.py	40	4	90%	252–253, 265–266
utils.py	47	3	94%	29–31, 101
array.py	26	9	65%	23, 28–33, 43, 49
biguint.py	101	6	94%	56, 100, 139, 155–156, 158
binary_bool_op.py	105	3	97%	154, 162, 172
bool.py	55	9	84%	39–43, 59, 70, 83, 97
bytes.py	168	18	89%	103–104, 131–132, 137–138, 144–145, 148, 156, 199, 234, 266, 270, 287–288, 303–304
compiled.py	70	9	87%	86–90, 127–131, 154
conditional_literal.py	134	34	75%	99, 103, 163, 167–170, 179–181, 204–207, 216, 220, 224–227, 242–254, 263–264, 275–278
contracts.py	77	8	90%	55, 61, 63, 73, 99, 109, 111, 116
dict.py	27	5	81%	25, 33–35, 39
ensure_budget.py	31	1	97%	47
interface.py	90	3	97%	314–316, 320
intrinsics.py	97	6	94%	43, 62, 69, 82, 89, 160
log.py	43	4	91%	46–47, 52, 61
logicsig.py	15	1	93%	26
none.py	27	1	96%	38
string.py	144	13	91%	72, 116–117, 136, 141, 184, 191, 195, 207, 281–283, 303
struct.py	16	5	69%	14–16, 25, 31
subroutine.py	80	16	80%	47, 51–54, 69, 72–79, 94, 102–103, 105–108, 113
template_variables.py	37	2	95%	30, 58
tuple.py	339	13	96%	86, 134, 150, 240–241, 253, 346–347, 466, 535, 546–547, 610
uint64.py	108	6	94%	57, 118–119, 167–168, 200
uint64_enums.py	40	2	95%	41, 46
unsigned_builtins.py	155	22	86%	74, 81, 105, 129, 133, 137, 141, 149, 153, 157, 161, 165, 175, 179, 185, 196, 202, 208, 247, 279, 291, 303
src/puyapy/awst_build/eb/arc4
_base.py	92	3	97%	185–188, 199
_utils.py	141	7	95%	119, 127, 138, 178–181, 252, 256
abi_call.py	317	19	94%	118, 124, 145, 215, 228–229, 310, 321, 379, 402, 433, 452–453, 512, 548, 622, 707–708, 725
address.py	73	2	97%	57, 116
bool.py	58	3	95%	42, 87–88
dynamic_array.py	120	9	92%	56, 123–124, 145, 221, 241–242, 245–248
dynamic_bytes.py	68	3	96%	99–101
emit.py	34	1	97%	36
static_array.py	62	1	98%	44
string.py	98	7	93%	54–55, 103, 124, 129–132
struct.py	49	1	98%	49
tuple.py	93	16	83%	45–47, 70, 88–91, 94–95, 134–137, 142, 146–147, 157, 167
ufixed.py	70	2	97%	43, 102
src/puyapy/awst_build/eb/reference_types
account.py	79	2	97%	65, 175
application.py	45	1	98%	40
asset.py	65	1	98%	48
src/puyapy/awst_build/eb/storage
_common.py	69	3	96%	107, 120–121
_storage.py	108	20	81%	58, 66, 70, 74, 78, 82, 86, 90, 94, 104, 108, 112, 116, 122, 133, 139, 145, 157–159
_value_proxy.py	55	7	87%	38, 42, 50, 54, 91, 99, 103
box_map.py	147	1	99%	194
global_state.py	127	6	95%	104–105, 114–115, 165–166
local_state.py	137	11	92%	99–100, 104, 151, 155, 159, 169, 173, 197, 254, 278
src/puyapy/awst_build/eb/transaction
base.py	39	2	95%	23, 43
group.py	53	1	98%	48
inner.py	48	2	96%	91–92
inner_params.py	77	5	94%	64, 74, 78, 138, 140
itxn_args.py	60	1	98%	72
TOTAL	22685	1703	92%

Tests	Skipped	Failures	Errors	Time
829	2 💤	0 ❌	0 🔥	5m 48s ⏱️