-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix immutability for ARC4 struct and address types #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-makerx
force-pushed
the
address-mutability
branch
from
October 28, 2024 03:51
0c5a18f
to
9ee0092
Compare
achidlow
previously approved these changes
Oct 28, 2024
daniel-makerx
force-pushed
the
address-mutability
branch
from
October 28, 2024 07:36
9ee0092
to
ad77f29
Compare
daniel-makerx
changed the title
fix:
fix: make Oct 28, 2024
algopy.arc4.Address
no longer allows mutationsalgopy.arc4.Address
immutable
daniel-makerx
changed the title
fix: make
fix immutability for ARC4 struct and address types
Oct 28, 2024
algopy.arc4.Address
immutable
daniel-makerx
force-pushed
the
address-mutability
branch
from
October 28, 2024 09:15
4d39d64
to
bc9a630
Compare
daniel-makerx
force-pushed
the
address-mutability
branch
from
October 29, 2024 05:50
bc9a630
to
edd8f2f
Compare
achidlow
previously approved these changes
Oct 29, 2024
Have found additional semantic compatibility issues around mutable arc4 types, which may require more breaking changes so converting to draft while addressing those |
daniel-makerx
force-pushed
the
address-mutability
branch
from
November 1, 2024 09:18
edd8f2f
to
2dc28c9
Compare
…s `algopy.arc4.Address` BREAKING CHANGE: modifying an `algopy.arc4.Address` will now raise an error
…table or not based on `frozen` class parameter and immutability of fields
…raise an error as allowing it would break semantic compatability BREAKING CHANGE: passing a mutable value more than once to a subroutine causes an error
…re the variable was last defined
BREAKING CHANGE: iterating a tuple of mutable types will now raise an error as they cannot be copied
daniel-makerx
force-pushed
the
address-mutability
branch
from
November 4, 2024 08:33
2dc28c9
to
0445005
Compare
achidlow
reviewed
Nov 5, 2024
achidlow
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: modifying an
algopy.arc4.Address
will now raise an error