Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace MakerX's Use-Wallet fork with TxnLab's ENG-350 #167

Merged
merged 1 commit into from
Jul 24, 2024
Merged

chore: replace MakerX's Use-Wallet fork with TxnLab's ENG-350 #167

merged 1 commit into from
Jul 24, 2024

Conversation

HashMapsData2Value
Copy link
Collaborator

Replace MakerX's Use-Wallet fork with TxnLab's.

@HashMapsData2Value HashMapsData2Value changed the title chore: replace MakerX's Use-Wallet fork with TxnLab's draft: chore: replace MakerX's Use-Wallet fork with TxnLab's Jul 10, 2024
@HashMapsData2Value HashMapsData2Value changed the title draft: chore: replace MakerX's Use-Wallet fork with TxnLab's draft: chore: replace MakerX's Use-Wallet fork with TxnLab's ENG-350 Jul 10, 2024
@HashMapsData2Value HashMapsData2Value changed the title draft: chore: replace MakerX's Use-Wallet fork with TxnLab's ENG-350 chore: replace MakerX's Use-Wallet fork with TxnLab's ENG-350 Jul 10, 2024
@ori-shem-tov
Copy link
Collaborator

@HashMapsData2Value is the api for manual signing the same?

@HashMapsData2Value
Copy link
Collaborator Author

HashMapsData2Value commented Jul 11, 2024 •
edited
Loading

@HashMapsData2Value is the api for manual signing the same?

https://www.npmjs.com/package/@makerx/use-wallet?activeTab=code
https://www.npmjs.com/package/@txnlab/use-wallet?activeTab=code

I went through the code under @makerx/use-wallet/dist/{cjs, esm}/src/clients/custom/ and @txnlab/use-wallet/dist/{cjs esm}/src/clients/custom/ and the code is the same. Our manual wallet relies on custom specifically.

Screenshot 2024-07-11 at 15 26 11

kylebeee
kylebeee approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@kylebeee kylebeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a swap from makerx to txnlab?
LGTM

only note would be make sure theres no interface changes between makerx's 3.0 version and txnlabs ^2.8.2

@HashMapsData2Value
Copy link
Collaborator Author

Just a swap from makerx to txnlab? LGTM

only note would be make sure theres no interface changes between makerx's 3.0 version and txnlabs ^2.8.2

Were you able to spin it up and try using the Use-Wallet component?

@HashMapsData2Value HashMapsData2Value merged commit 5be2869 into develop Jul 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebeee kylebeee kylebeee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HashMapsData2Value @ori-shem-tov @kylebeee