-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace node config reference with code generation. #1183
Conversation
Converted back to the draft. It doesn't seem to display properly: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it renders properly now. good stuff here
Just came across this after manually updating the page in #1186 🤦 |
Ouch. Did the automation do a good job? How do we get the process updated? |
The script works great! This is far better, thanks Will. I think ultimately we want it to be run as part of the I'm happy to approve this PR and get it merged in though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested again locally and am all for merging it in. @ryanRfox ?
With algorand/go-algorand#5729 the node config inline documentation is brought into alignment with the developer portal.
This PR uses the
config_json_gen
utility to render the node config reference page from the code comments.