fix: avoid ignoring on_complete if provided explicitly via transaction parameters

[aorumbayev]

Proposed Changes

• This was reported by @cusma. The main reason is potential confusion that can be caused by the fact that user has ability to specify on complete in transaction parameters, yet its ignored in some scenarios like opt_in (where it overwrites the oncomplete to use OptInOC).

For instance:

    app_client.opt_in( # this internally is actually going to ignore the on_compete from user and set it to OptInOC
        transaction_parameters=OnCompleteCallParameters(
            on_complete=OnComplete.DeleteApplicationOC
        ),
    )

As seen above, the usage may be confusing, we either want to limit ability to use OnCompleteCallParameters (currently its a sub class of transaction params hence why it works) or account to prioritize taking the on_complete from transaction params if present.

@robdmoore what's your opinion on this? The pr simply adds extra lines to prioritize taking the user's on_complete if it exists on transaction params object, otherwise default to dedicated on_complete param (which may or may not be pre-set by algokit typed client to specific on complete values).

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
src/algokit_utils
_debugging.py	140	7	95%	20, 41, 76, 80, 89, 129, 157
_ensure_funded.py	69	1	99%	99
_transfer.py	62	3	95%	13, 76–77
account.py	85	13	85%	14–17, 61–65, 96, 109, 136, 139, 183
application_client.py	533	77	86%	59–60, 166, 171, 200, 312, 317–318, 320, 322, 787, 802, 820–823, 913, 953, 965, 978, 1020, 1080–1086, 1090–1095, 1097, 1133, 1140, 1253, 1283, 1297, 1342–1344, 1346, 1356–1413, 1424–1429, 1449–1452
application_specification.py	97	11	89%	92, 94, 193–202, 206
asset.py	79	5	94%	9, 27–30
common.py	13	1	92%	13
config.py	51	18	65%	38–39, 50, 55, 60, 64–69, 100–109
deploy.py	459	24	95%	31–34, 169, 173–174, 191, 206, 247, 403, 414–422, 439–442, 452, 460, 653–654, 678
dispenser_api.py	82	12	85%	112–113, 117–120, 155–157, 176–178
logic_error.py	38	2	95%	6, 29
models.py	227	6	97%	45, 50–52, 61–62
network_clients.py	66	3	95%	89–90, 121
TOTAL	2015	183	91%

Tests	Skipped	Failures	Errors	Time
194	0 💤	0 ❌	0 🔥	2m 52s ⏱️