Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hotfixing the pkgutil.ImpImporter error when using 3.12 based pipx; adding dependabot; patching snapshot tests #72

Merged
merged 16 commits into from
Apr 16, 2024

Conversation

aorumbayev
Copy link
Contributor

@aorumbayev aorumbayev commented Apr 15, 2024

Proposed Changes

  • hotfix for behavior observed by @joe-p on https://github.com/algorandfoundation/algokit-utils-py/actions/runs/8689435772/job/23864221223?pr=71. The root cause as observed with Adam, seems to stem of from pipx and specifically affecting ubuntu-latest github worker image based containers (image comes shipped with pipx preinstalled with python 3.10). Our pipeline overwrites pipx however the initial 'shared' virtual env that is created by pre-bundled pipx is intact and that seems to cause the issue with pkgutil.ImpImporter - as pipx's managed venv for algokit is trying to access pkg_config available in shared pipx venv (which is a python 3.10 based venv).
  • propagating poetry action from algokit-cli repo. Also updating github actions to latest versions, setup python and checkout
  • configuring dependabot (mirroring our setup from utils-ts), to improve lockfile maintenance and faster resolution of transitive dependency issues.

TODO:

  • - Append reference to an issue to be opened on pipx repo

Copy link

github-actions bot commented Apr 16, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit_utils
   _debugging.py140795%20, 41, 76, 80, 89, 129, 157
   _ensure_funded.py69199%99
   _transfer.py62395%13, 76–77
   account.py851385%14–17, 61–65, 96, 109, 136, 139, 183
   application_client.py5489782%58–59, 100, 117, 168, 173, 202, 314, 319–320, 322, 324, 407, 416, 425, 475, 483, 492, 536, 544, 553, 597, 605, 614, 671, 679, 688, 730, 738, 747, 807, 822, 840–843, 933, 973, 985, 998, 1040, 1100–1106, 1110–1115, 1117, 1153, 1160, 1273, 1303, 1317, 1355–1357, 1359, 1369–1426, 1437–1442, 1462–1465
   application_specification.py971189%92, 94, 193–202, 206
   asset.py79594%9, 27–30
   common.py13192%13
   config.py511865%38–39, 50, 55, 60, 64–69, 100–109
   deploy.py4552495%30–33, 168, 172–173, 190, 205, 246, 402, 413–421, 438–441, 451, 459, 652–653, 677
   dispenser_api.py821285%112–113, 117–120, 155–157, 176–178
   logic_error.py38295%6, 29
   models.py126794%45, 50–52, 61–62, 125
   network_clients.py74396%106–107, 138
src/algokit_utils/beta
   account_manager.py551475%39–40, 64, 123–130, 183–187, 198–200
   algorand_client.py1011585%111–112, 121–122, 143–145, 154–155, 224, 259, 274, 290, 303, 319
   client_manager.py371073%40, 61–63, 68–70, 75–78
   composer.py3207178%335–336, 339–340, 343–344, 347–348, 355–356, 359–360, 389, 391, 393, 396, 399, 404, 407, 411, 414, 456–489, 494–505, 510–516, 521–529, 549–562, 566, 590, 593–610, 618, 643, 659–660, 662–663, 665–666, 668–669, 671–672, 678–682
TOTAL244631487% 

Tests Skipped Failures Errors Time
204 0 💤 0 ❌ 0 🔥 3m 12s ⏱️

@aorumbayev aorumbayev changed the title fix: testing ci fix: hotfixing the pkgutil.ImpImporter error when using 3.12 based pipx; adding dependabot; patching snapshot tests Apr 16, 2024
@aorumbayev aorumbayev marked this pull request as ready for review April 16, 2024 16:58
@aorumbayev aorumbayev requested a review from robdmoore April 16, 2024 17:01
@aorumbayev aorumbayev merged commit 770c84a into feat/algorand_client Apr 16, 2024
4 checks passed
@aorumbayev aorumbayev deleted the fix/ci-pipx-issues branch April 16, 2024 17:20
@aorumbayev aorumbayev restored the fix/ci-pipx-issues branch April 17, 2024 07:23
@aorumbayev aorumbayev deleted the fix/ci-pipx-issues branch April 17, 2024 10:12
joe-p added a commit that referenced this pull request Apr 26, 2024
* initial composer

* account and client manager

* build_group and execute

* WIP: algorand-client

* fix up algorand-client

* algorand-client -> algorand_client

* test_send_payment

* refactor params dataclasses

* fix sender params

* refactor txn params

* rm AlgoAmount

* beta namespace

* rm from __init__

* improve send_payment

* test_asset_opt_in

* addr -> address

* parity with JS tests

* ruff check --fix

* move account_manager to beta

* unsafe ruff fixes

* various fixes

* use match

* fix remaining ruff errors (other than line length and comments)

* assert rather than cast

* dont import from source

* use frozen dataclasses

* default get value

* instantiate dict

* using typing.Self

* fix some docstrings

* update idna due to vulnerability by pip-audit

* ruff

* ignore ruff errors in beta for now

* fix non sdk mypy stuff

* update cryptography for pip-audit

* rm comment

* ignore mypy errors

* ruff

* update setuptools

* chore: hotfixing the pkgutil.ImpImporter error when using 3.12 based pipx; adding dependabot; patching snapshot tests  (#72)

* fix: testing ci

* chore: testing ci

* chore: test

* chore: test

* chore: testing ci

* chore: testing ci

* chore: test

* chore: testing

* chore: test

* chore: test

* chore: removing tmp tweak

* chore: testing ci

* chore: lockfile maintenance (poetry update); reverting ci tweaks

* chore: testing ci

* chore: testing ci

* chore: testing ci

* tuple unpacking

---------

Co-authored-by: Al <[email protected]>
Co-authored-by: Altynbek Orumbayev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants