Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: task opt in and opt out #55

Merged
merged 17 commits into from
Oct 18, 2023
Merged

feat: task opt in and opt out #55

merged 17 commits into from
Oct 18, 2023

Conversation

negar-abbasi
Copy link
Contributor

@negar-abbasi negar-abbasi commented Oct 13, 2023

Proposed Changes

  • Adding opt in for multiple assets
  • Adding opt out for multiple assets

TODO:

  • More tests on error handling
  • fix other tests that works with old opt in function

src/algokit_utils/asset.py Outdated Show resolved Hide resolved
src/algokit_utils/asset.py Outdated Show resolved Hide resolved
src/algokit_utils/asset.py Outdated Show resolved Hide resolved
src/algokit_utils/asset.py Outdated Show resolved Hide resolved
src/algokit_utils/asset.py Outdated Show resolved Hide resolved
src/algokit_utils/asset.py Outdated Show resolved Hide resolved
src/algokit_utils/asset.py Outdated Show resolved Hide resolved
src/algokit_utils/__init__.py Outdated Show resolved Hide resolved
@aorumbayev
Copy link
Contributor

@negar-abbasi please also pull latest from main branch as well as its out of sync by a good # of commits

@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit_utils
   _ensure_funded.py69199%99
   _transfer.py62395%13, 76–77
   account.py851385%14–17, 61–65, 96, 109, 136, 139, 183
   application_client.py5519683%53–54, 111, 128, 179, 184, 213, 325, 330–331, 333, 335, 402, 411, 420, 470, 478, 487, 531, 539, 548, 592, 600, 609, 661, 669, 678, 720, 728, 737, 797, 812, 830–833, 909, 949, 961, 974, 1016, 1076–1082, 1086–1091, 1093, 1129, 1136, 1247, 1279, 1333–1335, 1337, 1347–1404, 1415–1420, 1440–1443
   application_specification.py971189%92, 94, 193–202, 206
   asset.py79594%9, 27–30
   config.py17759%13–18, 21–22
   deploy.py4552395%30–33, 168, 172–173, 190, 246, 402, 413–421, 438–441, 451, 459, 652–653, 677
   dispenser_api.py821285%112–113, 117–120, 155–157, 176–178
   logic_error.py38295%6, 30
   models.py126794%45, 50–52, 61–62, 125
   network_clients.py66395%89–90, 121
TOTAL173918389% 

Tests Skipped Failures Errors Time
190 0 💤 0 ❌ 0 🔥 2m 7s ⏱️

src/algokit_utils/asset.py Outdated Show resolved Hide resolved
@aorumbayev aorumbayev marked this pull request as ready for review October 18, 2023 08:53
@negar-abbasi negar-abbasi changed the title Feature/task opt in feat: task opt in and opt out Oct 18, 2023
@aorumbayev aorumbayev merged commit 3cf9238 into main Oct 18, 2023
2 checks passed
@aorumbayev aorumbayev deleted the feature/task-opt-in branch October 18, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants